#2140 Fixed reflection of hostname change #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopleus
requested review from
ohdearaugustin,
juanfont and
kradalby
as code owners
kradalby
reviewed
Oct 17, 2024
…in files according to golangci-lint rules
kradalby
approved these changes
Oct 17, 2024
|
Thank you! your help is much appreciated, I'm a bit overloaded at the moment, so I try to come to it as I have some spare moments. |
hopleus
added a commit
to hopleus/headscale
that referenced
this pull request
Oct 25, 2024
* juanfont#2140 Fixed updating of hostname and givenName when it is updated in HostInfo * juanfont#2140 Added integration tests * juanfont#2140 Fix unit tests * Changed IsAutomaticNameMode to GivenNameHasBeenChanged. Fixed errors in files according to golangci-lint rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2140