add autogroup:internet, fix reduce filter rules #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristoffer Dalby <[email protected]>
Updates juanfont#657 Updates juanfont#1786 Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
changed the title
This was referenced Apr 29, 2024
Closed
juanfont
approved these changes
Apr 29, 2024
|
|
||
| // theInternet returns the IPSet for the Internet. | ||
| // https://www.youtube.com/watch?v=iDbyYGrswtg | ||
| func theInternet() *netipx.IPSet { |
|
|
||
| // Delete Tailscale networks | ||
| internetBuilder.RemovePrefix(netip.MustParsePrefix("fd7a:115c:a1e0::/48")) | ||
| internetBuilder.RemovePrefix(netip.MustParsePrefix("100.64.0.0/10")) |
There was a problem hiding this comment.
Since you can define custom ip prefixes is it a good practice to assume the user is using the default tailscale network?
There was a problem hiding this comment.
The tailscale client does not support other up ranges, so while it is configurable in Headscale you cannot use anything else.
If that changes we could read it from the config.
Happy to take a pr changing it to the config values if you are up for it :)
There was a problem hiding this comment.
thanks to make it clear. didn't knew that and just read through the code and commented with my thoughts. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two features:
autogroup:internetfor policyThe majority of lines in this PR is tests based on #1817 and #1786.
Fixes #1817
Fixes #1786
Updates #657