-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #1860
Fix typos #1860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and shouldn't change any code logic.
Please run prettier on docs/web-ui.md |
done |
There have been a lot of changes can you please rebase the PR. |
Done |
There are still some conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete your secrets from the kustomize
I think we should just remove the whole kustomize stuff, I can open a pr for it tomorrow |
@ohdearaugustin opened for removing kustomize #1906 |
Should be in a sane state finally :-) |
synced with main again |
The unstable tailscale client is failing for the IntegrationTest (TestAuthKeyLogoutAndRelogin) this was not caused by this PR, but rather by an update of the client. @kradalby I hope it is okay to merge it. |
Yes it's been in the works for a bit, great getting it in |
Thanks |
Fix all typos found with https://github.com/crate-ci/typos, later we can add this to the CI to prevent further introduction of typos.