Adjust template for OIDC callback page (from #1435) #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsychov
force-pushed
the
change-oidc-template
branch
from
df7a515 to
e1997d0
Compare
|
Hello @juanfont, I hope this submission meets your approval for merging. |
|
@vsychov there is a couple of linter issues, would you mind fixing them? |
vsychov
force-pushed
the
change-oidc-template
branch
from
e1997d0 to
6d3c8ad
Compare
|
@juanfont , fixed |
vsychov
force-pushed
the
change-oidc-template
branch
from
6d3c8ad to
51b721d
Compare
|
@juanfont , all checks passed, maybe it can be merged? |
kradalby
force-pushed
the
change-oidc-template
branch
from
51b721d to
05c1d5b
Compare
vsychov
force-pushed
the
change-oidc-template
branch
from
05c1d5b to
1e97701
Compare
kradalby
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request enhances the user-friendliness of the OIDC callback page, as per the disagreement on relocating it to the config file as discussed in issue #1435.