Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report if a machine is online in CLI more accurately #1062

Merged
merged 5 commits into from
Dec 15, 2022
Merged

Report if a machine is online in CLI more accurately #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00e52a3
Include online field in proto for machine
juanfont Dec 13, 2022
6588a9c
Refresh autogenerated grpc stuff
juanfont Dec 13, 2022
c22e23c
Show online in CLI & API when isOnline() reports so
juanfont Dec 13, 2022
ea6b0c1
Update changelog
juanfont Dec 13, 2022
597977b
Merge branch 'main' into more-accurate-online
kradalby Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Reworked routing and added support for subnet router failover [#1024](https://github.com/juanfont/headscale/pull/1024)
- Added an OIDC AllowGroups Configuration options and authorization check [#1041](https://github.com/juanfont/headscale/pull/1041)
- Set `db_ssl` to false by default [#1052](https://github.com/juanfont/headscale/pull/1052)
- Report if a machine is online in CLI more accurately [#1062](https://github.com/juanfont/headscale/pull/1062)

## 0.17.1 (2022-12-05)

Expand Down
4 changes: 1 addition & 3 deletions cmd/headscale/cli/nodes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,7 @@ func nodesToPtables(
}

var online string
if lastSeen.After(
time.Now().Add(-5 * time.Minute),
) { // TODO: Find a better way to reliably show if online
if machine.Online {
online = pterm.LightGreen("online")
} else {
online = pterm.LightRed("offline")
Expand Down
179 changes: 94 additions & 85 deletions gen/go/headscale/v1/machine.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions gen/openapiv2/headscale/v1/headscale.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,6 +1111,9 @@
},
"givenName": {
"type": "string"
},
"online": {
"type": "boolean"
}
}
},
Expand Down
Loading