[Bug] "headscale node ls --tags" does not list tags after v0.24.0-beta.1 upgrade #2307
Closed
3 of 4 tasks
Comments
|
Thanks for the thorough writeup! are you able to test my fixes from here? #2309 |
|
Hey! Thanks for such a quick response. I have compiled your branch and tested the changes however it does not appear to have changed. The output is exactly the same. I added some prints to the following lines which appear to only ever return an empty array.
|
|
Just checking in the database |
|
hmm interesting, the valid tags is a product of the |
|
I'll attach a copy of my ACLs in a moment. I'll try replicate from a fresh setup and perform the upgrade again. |
|
Great, I just push another log line, so you can look for |
|
Here is the config.yaml and acls.json from |
|
hmm, I added a small test for what I think should be roughly equivalent to your config here db1aa9e, as I didnt test with the tag owner being a group, but it does look like it passes correctly. I'll be driving and then getting back to this. Not sure what this could be or what has changed, could you look for the |
|
Really appreciate the help, I will have to continue debugging tomorrow since its late now. I've attached some output that may or may not help and the logs you requested at the end. From the server From my workstation: (not sure why these are showing up as Logs from the server. |
Email takes precedence if available now, in the future, username will require an Actually, can you try to use your email in the If that work, you can use the email, right now this would be considered a regression as I didnt mean to push people towards emails yet. |
|
Changing the acls to use the email works correctly! |
|
ah awesome, that narrows down where I need to look, thank you, I will write a test so I can start figuring out what needs to be fixed. |
|
Thanks very much for your help. Please let me know if you need anything else. |
kradalby
added a commit
to kradalby/headscale
that referenced
this issue
Dec 18, 2024
Fixes juanfont#2300 Fixes juanfont#2307 Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
added a commit
that referenced
this issue
Dec 19, 2024
* ensure valid tags is populated on user gets too Signed-off-by: Kristoffer Dalby <[email protected]> * ensure forced tags are added Signed-off-by: Kristoffer Dalby <[email protected]> * remove unused envvar in test Signed-off-by: Kristoffer Dalby <[email protected]> * debug log auth/unauth tags in policy man Signed-off-by: Kristoffer Dalby <[email protected]> * defer shutdown in tags test Signed-off-by: Kristoffer Dalby <[email protected]> * add tag test with groups Signed-off-by: Kristoffer Dalby <[email protected]> * add email, display name, picture to create user Updates #2166 Signed-off-by: Kristoffer Dalby <[email protected]> * add ability to set display and email to cli Signed-off-by: Kristoffer Dalby <[email protected]> * add email to test users in integration Signed-off-by: Kristoffer Dalby <[email protected]> * fix issue where tags were only assigned to email, not username Fixes #2300 Fixes #2307 Signed-off-by: Kristoffer Dalby <[email protected]> * expand principles to correct login name and if fix an issue where nodeip principles might not expand to all relevant IPs instead of taking the first in a prefix. Signed-off-by: Kristoffer Dalby <[email protected]> * fix ssh unit test Signed-off-by: Kristoffer Dalby <[email protected]> * update cli and oauth tests for users with email Signed-off-by: Kristoffer Dalby <[email protected]> * index by test email Signed-off-by: Kristoffer Dalby <[email protected]> * fix last test Signed-off-by: Kristoffer Dalby <[email protected]> --------- Signed-off-by: Kristoffer Dalby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a support request?
Is there an existing issue for this?
Current Behavior
When running the command.
Shows
Nothing is listed in the
ValidTags,InvalidTags,ForcedTagscolumns.Expected Behavior
When running the command.
I expect the nodes tags to be displayed in the
ValidTags,InvalidTags,ForcedTagscolumns.Steps To Reproduce
headscale nodes ls --tagsEnvironment
Runtime environment
Anything else?
Even tho nothing is displayed in the output, ACLs seems to be working as if the tags were set correctly.
When running the command
tailscale debug netmapI can seeRequestTagsbeing returned.Running the following for a machine which I installed recently also does not return any tags.
Output:
The text was updated successfully, but these errors were encountered: