Integrate CardFlip #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to start with.. I appreciate your support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting the AccessbilityInfo not found errors (like #16 or #12) as well.
This is due to this library not specifying a react-native version in its dependencies, so it falls back to the react native version specified in react-native-card-flip (sth quite old like 0.49.1).
As react-native-card-flip is not maintained anymore and this library relying quite strongly on this, i moved the relevant part (
CardFlip.js) into this code base.These changes made the library work again for me without the errors and essentially fixes #16 and some of the comments from #12 (not the typescript definitions, but the comments hinting at the accessibilityInfo error)