test_runner: fix recursive run

PR-URL: nodejs#52322 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol · Apr 4, 2024 · 433bd1b · 433bd1b
1 parent f1f32d8
commit 433bd1b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -519,6 +519,8 @@ function run(options = kEmptyObject) {
   root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root);
 
   if (process.env.NODE_TEST_CONTEXT !== undefined) {
+    process.emitWarning('node:test run() is being called recursively within a test file. skipping running files.');
+    root.postRun();
     return root.reporter;
   }
   let testFiles = files ?? createTestFileList();

diff --git a/test/fixtures/test-runner/recursive_run.js b/test/fixtures/test-runner/recursive_run.js
@@ -0,0 +1,7 @@
+'use strict';
+
+const { test, run } = require('node:test');
+
+test('recursive run() calls', async () => {
+  for await (const event of run({ files: [__filename] }));
+});
diff --git a/test/parallel/test-runner-run.mjs b/test/parallel/test-runner-run.mjs
@@ -522,6 +522,18 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
     // eslint-disable-next-line no-unused-vars
     for await (const _ of stream);
   });
+
+  it('should avoid running recursively', async () => {
+    const stream = run({ files: [join(testFixtures, 'recursive_run.js')] });
+    let stderr = '';
+    stream.on('test:fail', common.mustNotCall());
+    stream.on('test:pass', common.mustCall(1));
+    stream.on('test:stderr', (c) => { stderr += c.message; });
+
+    // eslint-disable-next-line no-unused-vars
+    for await (const _ of stream);
+    assert.match(stderr, /Warning: node:test run\(\) is being called recursively/);
+  });
 });
 
 describe('forceExit', () => {