Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add point forecast #32

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Add point forecast #32

merged 3 commits into from
Jan 30, 2025

Conversation

howtodowtle
Copy link
Contributor

@howtodowtle howtodowtle commented Jan 29, 2025 •
edited
Loading

Description

This PR adds the ability to handle point-based forecasts.

Changes made:
if is_point_based:

  • Select region differently
  • Do not interpolate between grid but instead select the common stations by ID

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run poetry exec format to format my code
  • I have added tests that prove my fix is effective or that my feature works
  • [not needed imo] I have updated the documentation accordingly
  • All new and existing tests passed

@howtodowtle howtodowtle marked this pull request as ready for review January 29, 2025 19:28
aschl
aschl approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@aschl aschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Looks good to me. Thanks @howtodowtle

leoniewgnr
leoniewgnr approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, ready to merge?

@leoniewgnr leoniewgnr merged commit a77f6c2 into main Jan 30, 2025
2 checks passed
@leoniewgnr leoniewgnr deleted the add-point-forecast branch January 30, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoniewgnr leoniewgnr leoniewgnr approved these changes

@aschl aschl aschl approved these changes

@marvingabler marvingabler Awaiting requested review from marvingabler marvingabler is a code owner

@deepweather deepweather Awaiting requested review from deepweather deepweather is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howtodowtle @leoniewgnr @aschl