Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for regions #18

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Test for regions #18

merged 3 commits into from
Jan 16, 2025

Conversation

aschl
Copy link
Contributor

@aschl aschl commented Jan 16, 2025

Description

Added test for regions

Checklist

  • I have run poetry exec format to format my code
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed

Closes #

leoniewgnr
leoniewgnr approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm!

@aschl aschl merged commit 89ffc18 into main Jan 16, 2025
2 checks passed
@aschl aschl deleted the region-test branch January 16, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoniewgnr leoniewgnr leoniewgnr approved these changes

@marvingabler marvingabler Awaiting requested review from marvingabler marvingabler is a code owner

@deepweather deepweather Awaiting requested review from deepweather deepweather is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschl @leoniewgnr