Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asterisks not treated as emphasize/strong text delimiters #15

Open
echristopherson opened this issue Mar 12, 2014 · 1 comment
Open

Asterisks not treated as emphasize/strong text delimiters #15

echristopherson opened this issue Mar 12, 2014 · 1 comment

Comments

@echristopherson
Copy link

Text between asterisks isn't highlighted as emphasized or strong, as text between underscores is (unlike with tpope's syntax file).

Also unlike with tpope's markdown, vim-flavored-markdown doesn't make a visual distinction between emphasized, strong, and emphasized strong.
@jtratner
Copy link
Owner

@echristopherson sorry I let this slide, I noticed this too. Going to try to pull in tpope's markdown again this weekend (this is really just a few tweaks on top of it) and see if this resolves the problem.

aaaaalbert added a commit to aaaaalbert/vim-flavored-markdown that referenced this issue Jul 19, 2017
@aaaaalbert
Fix jtratner#15, bold formatting with asterisks (``*'')
d92bc37 
This commit reenables emphasis highlighting for Markdown text that
is fenced by asterisks, *like so*.
It actually updates the definitions for regions `markdownItalic`,
`markdownBold`, `markdownBoldItalic`, and `markdownCode` from @tpope's
`markdown.vim` from 2010-05-21 (which I had lying around locally).

A quick local test indicates that the patch works as intended, albeit
with slight changes in appearance of formatted text:

Example  -- previous style -- current style
*word*   -- no formatting  -- italic (as planned)
_word_   -- italic         -- italic
**word** -- no formatting  -- bold
__word__ -- italic         -- bold (see below)

Formatting double-underscore as bold follows GitHub's style, see
https://help.github.com/articles/basic-writing-and-formatting-syntax/

Note: tpope/vim-markdown@a7dbc31 would
be the current up-to-date version of the base plugin, but there have
been changes to it that look incompatible with the rest of what's here
so I'm basing my work on the old version instead.
aaaaalbert added a commit to aaaaalbert/vim-flavored-markdown that referenced this issue Jul 19, 2017
@aaaaalbert
Fix jtratner#15, bold formatting with asterisks (``*'')
112eb25 
This commit reenables emphasis highlighting for Markdown text that
is fenced by asterisks, *like so*.
It actually updates the definitions for regions `markdownItalic`,
`markdownBold`, `markdownBoldItalic`, and `markdownCode` from @tpope's
`markdown.vim` from 2010-05-21 (which I had lying around locally).

A quick local test indicates that the patch works as intended, albeit
with slight changes in appearance of formatted text:

Example  -- previous style -- current style
*word*   -- no formatting  -- italic (as planned)
_word_   -- italic         -- italic
**word** -- no formatting  -- bold
__word__ -- italic         -- bold (see below)

Formatting double-underscore as bold follows GitHub's style, see
https://help.github.com/articles/basic-writing-and-formatting-syntax/

Note: tpope/vim-markdown@a7dbc31 would
be the current up-to-date version of the base plugin, but there have
been changes to it that look incompatible with the rest of what's here
so I'm basing my work on the old version instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@echristopherson @jtratner