Fix unused hostvars array when grouping hosts

[Termina1]

Currently if there is no group defined explicitly and they are defined when checking hosts, there always will be only one host in each group

[jtopjian]

@Termina1 Thanks for submitting this.

If I recall correctly, appending to hostInventory was supposed to have the same effect as appending to groupInventory["hosts"], since changes to hostInventory should have updated groupInventory. But maybe that was never the case...

Would you be able to update the test files to confirm this behaviour and to help prevent regression in the future?

[Termina1]

Sometimes it can be counter-intuitive, but it's not the same effect. After appending to slice, you must assign result to a variable, otherwise it won't take effect.
You can read here: https://go.dev/blog/slices-intro

[jtopjian]

@Termina1 Right, thank you! Though would you still be able to add one or more test cases to this PR to ensure it's accounted for?

[Termina1]

I would have to fix the tests first, because they don’t work on OSX I can give you tfstate which produces invalid unexpected inventory

[jtopjian]

I've been able to get the tests running on OS X and have written a test case for this. I'm going to merge this and follow-up with an additional PR for the tests.

[jtopjian]

LGTM - thank you!

[jtopjian]

@Termina1 v0.3.1 has been released with this fix: https://github.com/jtopjian/ansible-terraform-inventory/releases/tag/v0.3.1

Please let me know if you have any issues with it.

[Termina1]

Cool, thanks!