Python checks no longer work

[jtojnar]

The overlay produced by checkBuildPythonPackageFor no longer appears to override buildPythonPackage:

nixpkgs-hammering/lib/default.nix

Lines 83 to 111 in 54411aa

	final:
	prev:
	let
	# Keep in sync with Nixpkgs’s all-packages.nix. Look for `inherit (pythonInterpreters)`.
	# No need to include e.g. `python3`, since that is derived from one of the listed.
	pythonPackageSetNames = [
	"python2"
	"python38"
	"python39"
	"python310"
	"python311"
	"python312"
	"python3Minimal"
	"pypy27"
	"pypy39"
	"pypy38"
	"pypy37"
	"rustpython"
	];
	in
	lib.genAttrs pythonPackageSetNames (pythonName:
	prev.${pythonName}.override (oldOverrides: {
	packageOverrides = lib.composeExtensions (oldOverrides.packageOverrides or idOverlay) (final: prev: {
	buildPythonPackage = wrapFunctionWithChecks prev.buildPythonPackage check;
	});
	})
	);

And the one from checkFor does not seem to apply to mkDerivation used by buildPythonPackage internally (even though it works for packages using stdenv.mkDerivation directly:

nixpkgs-hammering/lib/default.nix

Lines 69 to 76 in 54411aa

	final:
	prev:
	{
	stdenv = prev.stdenv // {
	mkDerivation = wrapFunctionWithChecks prev.stdenv.mkDerivation check;
	};
	};

I bisected the breakage to NixOS/nixpkgs@33d12e5

[AkechiShiro]

Hi @jtojnar is this still relevant today?

[jtojnar]

@AkechiShiro Yes, I have not found the time to fix this yet.

[AkechiShiro]

How can I help investigate/fix this, it looks a bit complicated due to the nature of the change that was made upstream ? What do you recommend me to do so I can dig into this and help you maybe get closer to fix it, I don't know if I'll be able to as this is my first contribution to this nix community project.

[jtojnar]

You can clone nixpkgs-hammering and revert bc495ee, and try to make the tests pass by tweaking the overlays.
You can also try to look at NixOS/nixpkgs@33d12e5 and tweak it and try to run tests with the updated Nixpkgs usingnix shell --override-input nixpkgs . ~/Projects/nixpkgs-hammering -c ./run-tests.py

It does not matter if it is your contribution but it will be pretty hard so it depends on how you are proficient with Nix or comfortable reading the overlay and fix-point heavy Nix code for stdenv and Python packaging.

[AkechiShiro]

Fine, thanks for the detailed instructions @jtojnar, let me take up this challenge, if I fail, I'll only have learned more, no one can fix everything on their first tries.