Skip to content

Commit

Permalink
[BEAM-9274] Support running yapf in a git pre-commit hook
Browse files Browse the repository at this point in the history
  • Loading branch information
chadrik committed Mar 3, 2020
1 parent 873f689 commit e07e65b
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
32 changes: 32 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

repos:
- repo: https://github.com/pre-commit/mirrors-yapf
# this rev is a release tag in the repo above and corresponds with a yapf
# version. make sure this matches the version of yapf in tox.ini.
rev: v0.29.0
hooks:
- id: yapf
files: ^sdks/python/apache_beam/
# keep these in sync with sdks/python/.yapfignore
exclude: >
(?x)^(
sdks/python/apache_beam/io/gcp/internal/clients/bigquery/bigquery_v2_client.py|
sdks/python/apache_beam/io/gcp/internal/clients/bigquery/bigquery_v2_messages.py|
sdks/python/apache_beam/runners/dataflow/internal/clients/dataflow/dataflow_v1b3_client.py|
sdks/python/apache_beam/runners/dataflow/internal/clients/dataflow/dataflow_v1b3_messages.py|
sdks/python/apache_beam/io/gcp/internal/clients/storage/storage_v1_client.py|
sdks/python/apache_beam/io/gcp/internal/clients/storage/storage_v1_messages.py|
sdks/python/apache_beam/coders/proto2_coder_test_messages_pb2.py|
sdks/python/apache_beam/portability/api/.*pb2.*.py
)$
2 changes: 2 additions & 0 deletions sdks/python/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -348,13 +348,15 @@ commands =
commands_pre =

[testenv:py3-yapf]
# keep the version of yapf in sync with the 'rev' in .pre-commit-config.yaml
deps =
yapf==0.29.0
commands =
yapf --version
time yapf --in-place --parallel --recursive apache_beam

[testenv:py3-yapf-check]
# keep the version of yapf in sync with the 'rev' in .pre-commit-config.yaml
deps =
yapf==0.29.0
commands =
Expand Down

0 comments on commit e07e65b

Please sign in to comment.