forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add tests around accessing field aliases in scripts. (elastic#31417)
* Make sure aliases can be referenced through params._fields. * Make sure aliases can be accessed through 'doc'. * Convert ExpressionTests to a unit test.
- Loading branch information
1 parent
8e74f21
commit 01b4918
Showing
4 changed files
with
234 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
server/src/test/java/org/elasticsearch/search/lookup/LeafDocLookupTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.elasticsearch.search.lookup; | ||
|
|
||
| import org.elasticsearch.index.fielddata.AtomicFieldData; | ||
| import org.elasticsearch.index.fielddata.IndexFieldData; | ||
| import org.elasticsearch.index.fielddata.ScriptDocValues; | ||
| import org.elasticsearch.index.mapper.MappedFieldType; | ||
| import org.elasticsearch.index.mapper.MapperService; | ||
| import org.elasticsearch.test.ESTestCase; | ||
| import org.junit.Before; | ||
|
|
||
| import static org.mockito.AdditionalAnswers.returnsFirstArg; | ||
| import static org.mockito.Matchers.anyObject; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class LeafDocLookupTests extends ESTestCase { | ||
| private ScriptDocValues<?> docValues; | ||
| private LeafDocLookup docLookup; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| super.setUp(); | ||
|
|
||
| MappedFieldType fieldType = mock(MappedFieldType.class); | ||
| when(fieldType.name()).thenReturn("field"); | ||
| when(fieldType.valueForDisplay(anyObject())).then(returnsFirstArg()); | ||
|
|
||
| MapperService mapperService = mock(MapperService.class); | ||
| when(mapperService.fullName("field")).thenReturn(fieldType); | ||
| when(mapperService.fullName("alias")).thenReturn(fieldType); | ||
|
|
||
| docValues = mock(ScriptDocValues.class); | ||
|
|
||
| AtomicFieldData atomicFieldData = mock(AtomicFieldData.class); | ||
| doReturn(docValues).when(atomicFieldData).getScriptValues(); | ||
|
|
||
| IndexFieldData<?> fieldData = mock(IndexFieldData.class); | ||
| when(fieldData.getFieldName()).thenReturn("field"); | ||
| doReturn(atomicFieldData).when(fieldData).load(anyObject()); | ||
|
|
||
| docLookup = new LeafDocLookup(mapperService, | ||
| ignored -> fieldData, | ||
| new String[] { "type" }, | ||
| null); | ||
| } | ||
|
|
||
| public void testBasicLookup() { | ||
| ScriptDocValues<?> fetchedDocValues = docLookup.get("field"); | ||
| assertEquals(docValues, fetchedDocValues); | ||
| } | ||
|
|
||
| public void testLookupWithFieldAlias() { | ||
| ScriptDocValues<?> fetchedDocValues = docLookup.get("alias"); | ||
| assertEquals(docValues, fetchedDocValues); | ||
| } | ||
| } |
104 changes: 104 additions & 0 deletions
104
server/src/test/java/org/elasticsearch/search/lookup/LeafFieldsLookupTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.elasticsearch.search.lookup; | ||
|
|
||
| import org.apache.lucene.index.DocValuesType; | ||
| import org.apache.lucene.index.FieldInfo; | ||
| import org.apache.lucene.index.IndexOptions; | ||
| import org.apache.lucene.index.LeafReader; | ||
| import org.apache.lucene.index.StoredFieldVisitor; | ||
| import org.elasticsearch.Version; | ||
| import org.elasticsearch.cluster.metadata.IndexMetaData; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.index.IndexSettings; | ||
| import org.elasticsearch.index.mapper.MappedFieldType; | ||
| import org.elasticsearch.index.mapper.MapperService; | ||
| import org.elasticsearch.test.ESTestCase; | ||
| import org.junit.Before; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| import static org.mockito.AdditionalAnswers.returnsFirstArg; | ||
| import static org.mockito.Matchers.any; | ||
| import static org.mockito.Matchers.anyInt; | ||
| import static org.mockito.Matchers.anyObject; | ||
| import static org.mockito.Mockito.doAnswer; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class LeafFieldsLookupTests extends ESTestCase { | ||
| private LeafFieldsLookup fieldsLookup; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| super.setUp(); | ||
|
|
||
| IndexSettings indexSettings = new IndexSettings( | ||
| IndexMetaData.builder("index") | ||
| .settings(Settings.builder().put(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT)) | ||
| .numberOfShards(1) | ||
| .numberOfReplicas(0) | ||
| .build(), Settings.EMPTY); | ||
|
|
||
| MappedFieldType fieldType = mock(MappedFieldType.class); | ||
| when(fieldType.name()).thenReturn("field"); | ||
| when(fieldType.valueForDisplay(anyObject())).then(returnsFirstArg()); | ||
|
|
||
| MapperService mapperService = mock(MapperService.class); | ||
| when(mapperService.getIndexSettings()).thenReturn(indexSettings); | ||
| when(mapperService.fullName("field")).thenReturn(fieldType); | ||
| when(mapperService.fullName("alias")).thenReturn(fieldType); | ||
|
|
||
| FieldInfo mockFieldInfo = new FieldInfo("field", 1, false, false, true, | ||
| IndexOptions.NONE, DocValuesType.NONE, -1, Collections.emptyMap(), 0, 0, false); | ||
|
|
||
| LeafReader leafReader = mock(LeafReader.class); | ||
| doAnswer(invocation -> { | ||
| Object[] args = invocation.getArguments(); | ||
| StoredFieldVisitor visitor = (StoredFieldVisitor) args[1]; | ||
| visitor.doubleField(mockFieldInfo, 2.718); | ||
| return null; | ||
| }).when(leafReader).document(anyInt(), any(StoredFieldVisitor.class)); | ||
|
|
||
| fieldsLookup = new LeafFieldsLookup(mapperService, | ||
| new String[] { "type" }, | ||
| leafReader); | ||
| } | ||
|
|
||
| public void testBasicLookup() { | ||
| FieldLookup fieldLookup = (FieldLookup) fieldsLookup.get("field"); | ||
| assertEquals("field", fieldLookup.fieldType().name()); | ||
|
|
||
| List<Object> values = fieldLookup.getValues(); | ||
| assertNotNull(values); | ||
| assertEquals(1, values.size()); | ||
| assertEquals(2.718, values.get(0)); | ||
| } | ||
|
|
||
| public void testLookupWithFieldAlias() { | ||
| FieldLookup fieldLookup = (FieldLookup) fieldsLookup.get("alias"); | ||
| assertEquals("field", fieldLookup.fieldType().name()); | ||
|
|
||
| List<Object> values = fieldLookup.getValues(); | ||
| assertNotNull(values); | ||
| assertEquals(1, values.size()); | ||
| assertEquals(2.718, values.get(0)); | ||
| } | ||
| } |