Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SvelteKit CR update with better Firebase config parsing #18

Merged
merged 20 commits into from
Mar 15, 2021
Merged

feat: SvelteKit CR update with better Firebase config parsing #18

merged 20 commits into from
Mar 15, 2021

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Mar 14, 2021 •
edited
Loading

Summary

  • support new SvelteKit adapter API introduced in https://github.com/sveltejs/kit/blob/master/packages/kit/ version 1.0.0-next.46
  • improve Firebase config parsing
    • remove joi dep
    • simplify validation logic and extract into utils.js
    • extract and return only values required so no further parsing is required
    • tests for each error case of config parsing (success cases already covered)
    • validate the serviceId field against Cloud Run service requirements
  • make an ESM module with package.json "type":"module"
    • update commitlint.config to .cjs
  • remove handling of functions for rewrites until solution to bug: ESM not supported in Node.js 14 environment #16 is found
  • remove min NodeJS version as other adapters do not list this field (SvelteKit probably defines this)
  • update docs to show current support
  • working Cloud Run implementation

Fixes: #17

@jthegedus
chore: gitignore updates and nodejs version bump
14d508b
@jthegedus
refactor: esm, remove joi, types with jsdoc, improve firebase config …
c3f4506 
…parsing
@jthegedus
chore: bump nodejs version
6522b64
@jthegedus
chore: update deps
cb1ac49
@jthegedus
fix: camelcase for cloudRun var name
5ec4943
@jthegedus
fix: tests and add more cases
b5770a9
@jthegedus
test: cover all branches of parseFirebaseConfig function
34972c2
@jthegedus
fix: remove unused comment
c08014d
@jthegedus
docs: remove todo item for removing Joi
3cd367d
@jthegedus
chore: remove engines as other adapters do not use this
7532186
@jthegedus
docs: fix some errors, clarify existing support
8abd703
@jthegedus
feat: validate cloud run serviceId in firebase.json config
1399f1c
@jthegedus
chore: document and type isString func
cdc5376
@jthegedus
docs: mark Cloud Run as recommended
9bd4ebc
@jthegedus
docs: reorder features list
721314d
@jthegedus
refactor: working cloud run 🎉
e5df321
@jthegedus
refactor: use pnpm instead of npm
d645da8
@jthegedus
docs: list status of Firebase Emulator support
49cce99
@jthegedus
refactor: cloud run support with automatic package.json generation
3065197
@jthegedus
fix: functions framework entrypoing fix for Cloud Run
6637162
@jthegedus jthegedus changed the title feat: SvelteKit updates with better Firebase config parsing feat: SvelteKit CR update with better Firebase config parsing Mar 15, 2021
@jthegedus jthegedus merged commit 42ddb0c into main Mar 15, 2021
@jthegedus jthegedus deleted the refactor/sveltekit-updates-firebase-config-parsing branch March 15, 2021 06:52
github-actions bot pushed a commit that referenced this pull request Mar 15, 2021
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
d0cf20e 
# [0.4.0](v0.3.3...v0.4.0) (2021-03-15)

### Features

* SvelteKit CR update with better Firebase config parsing ([#18](#18)) ([42ddb0c](42ddb0c))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jthegedus jthegedus mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing tests
1 participant
@jthegedus