-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#172): Remove reference to obsoleted writeStatic
#173
Conversation
package.json
Outdated
@@ -21,7 +21,7 @@ | |||
"serverless", | |||
"ssr" | |||
], | |||
"version": "0.14.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't change this or the Changelog manually, it will be done by automation during release.
@@ -95,7 +95,6 @@ const entrypoint = function (options = {}) { | |||
builder.rimraf(publicDir); | |||
|
|||
builder.log.minor(logRelativeDir('Writing client application to', publicDir)); | |||
builder.writeStatic(publicDir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this replaced with anything? How are these files now being written?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I'm just experimenting with the adapter, but stuck on this error. Any guidance? Just wait for this to be resolved? pin to an earlier version of SvelteKit? Thoughts? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like it was replaced with anything else on the adapter-vercel
sveltejs/kit@8191720
I'll give this a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PR5618:
Have writeClient write both the client and static files and remove writeStatic. This is a breaking change for adapter authors.
writeClient
does job for writeStatic
so I removed writeStatic
.
Summary
Fixes broken build with breaking change introduced in SvelteKit PR5618.
Fixes: #172