[Don't merge] Add reuse of scratch space to LCOW snapshotter #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directly editing vendored containerd here just for ease of review/to see it all in one place. Will split out into actual containerd if this approach seems fine. Signed-off-by: Daniel Canter <[email protected]>
|
@kevpar @ambarve @katiewasnothere Forgot to @ you 😄 |
dcantah
changed the title
|
Just going to close this and make a new PR with only the cri work needed and push the containerd work to Kevins new fork, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly editing vendored containerd here just for ease of review/to see it all in one place.
Will split out into actual containerd if this approach seems fine.
Signed-off-by: Daniel Canter [email protected]