Support .yml extension in migration names, add Travis config #35
Conversation
…ith library 2.2.0.0)
|
PR is ready for review. |
|
Thanks for the patches. I seem to recall you mentioning that the move to |
|
Fair enough. Thanks for review; I'm going to revisit string types in one-two days. |
Exceptions: - String is the only serialization data type supported by HDBC - FilePaths
viviag
force-pushed
the
viviag_patch
branch
from
07ba6b6 to
4bb9433
Compare
|
Fixed. |
dbmigrations.cabal
Outdated
| test-suite dbmigrations-tests | ||
| default-language: Haskell2010 | ||
| default-extensions: OverloadedStrings |
There was a problem hiding this comment.
Can you please move this to the relevant modules with explicit pragmas?
| getFields (YMap mp) = map toPair $ Map.assocs mp | ||
| where | ||
| toPair (YStr k, YStr v) = (unpack k, unpack v) | ||
| toPair (YStr k, YStr v) = (T.decodeUtf8 k, T.decodeUtf8 v) |
There was a problem hiding this comment.
Due to this change, can you also update MOO.TXT to mention that migrations are assumed to be UTF-8 encoded?
|
Fixed. |
|
Okay, these changes look okay to me. Have you tried them with the backend-specific wrappers? If not, please ensure that those have update patches, too. https://github.com/jtdaugherty/dbmigrations-postgresql |
|
jtdaugherty/dbmigrations-mysql#2 Two other tools are up to date. |
Partly covers changes, mentioned in discussion on #34