Switch to new eslint rule format (Fixes #661) #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Presumably all the authors of open PRs can run the same transformation and the resulting diffs should be just as useful? (linking to #686) |
|
Should be, might be a little weird since their branch will be trying to do the same changes as this one. Though its possible that running the tool and then doing a rebase might clean things up for them. |
|
Yes, definitely they'd want to do a rebase. Always be rebasing! |
petersendidit
force-pushed
the
NewRuleFormat
branch
2 times, most recently
from
70645d6 to
7121cbd
Compare
petersendidit
force-pushed
the
NewRuleFormat
branch
from
7121cbd to
b0f6dab
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided automatic transformation from eslint worked great.
Merging this will most likely result in conflicts in all open pull requests.