Add in an "all" config #683
Conversation
|
These should probably be a superset of the "recommended" config - what about these options https://github.com/yannickcr/eslint-plugin-react/blob/master/index.js#L68-L69 ? |
|
That's a good point. I would say that "all" should be every rule in it's default configuration, and I would also say it's okay for "recommended" to deviate from default configurations (to ones that might be preferred). But I'm happy to update this to be a superset of recommended if you disagree |
|
Also, what do you think is the best for |
| }); | ||
| it('should export a \'all\' configuration', function() { | ||
| assert(plugin.configs.all); | ||
| Object.keys(plugin.configs.all.rules).forEach(function(configName) { |
There was a problem hiding this comment.
this seems like it now no longer verifies that every rule is included?
It is important to have a test that fails when someone adds a new rule but forgets to add it to "all"
There was a problem hiding this comment.
Yes, you are right, I will fix tha
|
Nice. Can you also update the Readme? |
|
Sure thing, I've updated the README now |
|
Thanks, can you rebase your branch? Then I think we'll be good to go :) |
|
Done, should be good to go now |
|
Merged, thanks! |
Much like eslint:all
http://eslint.org/docs/user-guide/configuring#using-eslintall