Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] update configuration URL #3582

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

gokaygurcan
Copy link
Contributor

Hi,

When I run eslint on some React files, this is what I get:

$ npm run lint:js

> @gokaygurcan/[email protected] lint:js
> eslint --config .eslintrc --color .

Warning: React version not specified in eslint-plugin-react settings. See https://github.com/jsx-eslint/eslint-plugin-react#configuration .

And the given URL resolves the repository, but doesn't scroll to the anchored place because of this change: 17858be#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R20

This PR is here to fix the URL and point the correct location.

I hope this makes sense. Thanks in advance for your consideration.

Best,
G.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #3582 (967b9f2) into master (747fad0) will not change coverage.
The diff coverage is n/a.

❗ Current head 967b9f2 differs from pull request most recent head 693860f. Consider uploading reports for the commit 693860f to get more accurate results

@@           Coverage Diff           @@
##           master    #3582   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files         132      132           
  Lines        9295     9295           
  Branches     3400     3400           
=======================================
  Hits         9074     9074           
  Misses        221      221           

@gokaygurcan
Copy link
Contributor Author

Error: This pull request must have the “allow edits” checkbox checked.

Well, that's a weird requirement, but here we go.

@ljharb
Copy link
Member

ljharb commented Jun 1, 2023

Thanks! Instead of changing the outputted URL, can we add <a id="configuration"></a> in the appropriate place, so that the broken URL works again? Cool URLs don't change, and we don't want to be uncool :-)

@gokaygurcan
Copy link
Contributor Author

That's a better idea. I sure can do it like that. Lemme do some clickety-click and get back to you.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the patch-1 branch 2 times, most recently from a93e1a2 to be3eead Compare June 5, 2023 19:01
@ljharb
Copy link
Member

ljharb commented Jun 5, 2023

@gokaygurcan

Well, that's a weird requirement, but here we go.

it's checked by default, and it allows maintainers to rebase and adjust your PR branch as needed to land it. I've always found it weird that people sometimes un check it ¯\_(ツ)_/¯

@ljharb ljharb merged commit 693860f into jsx-eslint:master Jun 5, 2023
@gokaygurcan
Copy link
Contributor Author

Thanks a lot ^_^

@gokaygurcan gokaygurcan deleted the patch-1 branch June 6, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants