Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link does not end with '.' #2103

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Link does not end with '.' #2103

merged 1 commit into from
Jan 2, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jan 2, 2019

Fix link hash #

ljharb
ljharb approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but what URL parser is having trouble with this?

@yoyo837
Copy link
Contributor Author

yoyo837 commented Jan 2, 2019

It prints to the console, such as vscode , and can't scroll to the anchored location after clicking the link.

@ljharb ljharb merged commit 11a66c0 into jsx-eslint:master Jan 2, 2019
@yoyo837 yoyo837 deleted the patch-1 branch January 2, 2019 07:17
This was referenced Jan 2, 2019
Closed
Open
Open
Merged
Merged
Closed
Closed
Open
Merged
Merged
Open
Merged
Open
Merged
Open
Open
Open
Closed
Open
Merged
Open
Open
Closed
Merged
This was referenced Jan 8, 2019
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@ghost ghost mentioned this pull request Jan 12, 2019
Merged
1 task
This was referenced Jan 13, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 17, 2019
Open
Open
This was referenced Sep 22, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyo837 @ljharb