Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow Union tests for no-unused-prop-types and prop-types with import #1570

Merged

Conversation

justinanastos
Copy link
Contributor

Please note this only tests that using import and Union propTypes won't crash eslint. This does not actually test that the propTypes are not unused or that they are defined when used.

Contributes to issue #1468

@ljharb ljharb added the flow label Nov 24, 2017
@ljharb ljharb merged commit e5e4536 into jsx-eslint:master Nov 24, 2017
@justinanastos justinanastos deleted the fix/prop-types-union-flowtype-1468 branch November 24, 2017 14:47
@justinanastos
Copy link
Contributor Author

justinanastos commented Nov 24, 2017

Thank you @ljharb ! This is my first time contributing to this package. What is your procedure/requirement/schedule for cutting npm releases?

@justinanastos
Copy link
Contributor Author

Thanks for the awesome work @ljharb . This package is amazing.

@ljharb
Copy link
Member

ljharb commented Nov 24, 2017

Only @yannickcr can publish a release; we'll have to wait for them to do so.

@justinanastos
Copy link
Contributor Author

In that case, thank you to @yannickcr for this awesome plugin too.

@justinanastos
Copy link
Contributor Author

@yannickcr Can you cut a release?

@yannickcr
Copy link
Member

Hi @justinanastos, thanks for your contribution ❤️ and sorry for the delay. I'm working on a new release and it should be out soon.

I will also work with @ljharb to avoid theses long delay between release.

@justinanastos
Copy link
Contributor Author

No need to apologize @yannickcr ! Thanks for building a great tool that thousands of people use every day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants