Use full schema object instead of an array for jsx-curly-spacing #1292
Conversation
|
@yannickcr it'd be great to release this as a semver-patch ASAP (assuming nothing minor or major is already in master) |
BREAKING CHANGE: [email protected] or higher is now a peer dependency Added rules: * [`react/no-find-dom-node`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-find-dom-node.md) * [`react/no-redundant-should-component-update`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-redundant-should-component-update.md) * [`getter-return`](http://eslint.org/docs/rules/getter-return) * [`multiline-ternary`](http://eslint.org/docs/rules/multiline-ternary) * [`object-curly-newline`](http://eslint.org/docs/rules/object-curly-newline) * [`semi-style`](http://eslint.org/docs/rules/semi-style) * [`switch-colon-spacing`](http://eslint.org/docs/rules/switch-colon-spacing) Added options: * * `{"ignoreComments": true}` for [`no-trailing-spaces`](http://eslint.org/docs/rules/no-trailing-spaces) * `{"newlines-between": "always-and-inside-groups"}` for [`import/order`](https://github.com/benmosher/eslint-plugin-import/blob/HEAD/docs/rules/order.md) [`react/jsx-curly-spacing`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md) is temporarily disabled until a [fix](jsx-eslint/eslint-plugin-react#1292) gets published
|
Is there something which is blocking publishing a release with this PR? Not having it is blocking upgrades from eslint 4.1.1 to 4.2.0. |
|
@ZebraFlesh in fact this PR is not necessary for upgrading to eslint 4.2.0; the v4.2.0 upgrade is necessary to avoid an error. This PR enforces the schema - without this PR, invalid configs pass. |
|
@ljharb is it that 4.2 doesn't bail with an error but still logs an error message? That's what I experience and why I've decided to wait for this to be published before upgrading. |
|
@lukeapage yes, exactly - it logs an error message (which is easily ignored) but no longer fails. You're welcome to wait, but it's not really "blocking", it's just slightly inconvenient :-) |
|
That's exactly what I'm talking about: I don't want to try and explain to everyone why there are new errors in the logs and why they're okay. |
|
The error you refer to @ljharb, is manifested as a dialog box when running eslint in Sublime Text. Which is less easy to ignore. You're even worse-off if you have your files be auto-linted on save, and worse still when you have your files auto-saved when the document loses focus (switching tabs, documents, apps, etc). So literally every time I switch windows, change documents, or anything meaningful, I see this warning dialog box. I'm not saying this is a majority case at all, I'm just saying that there are other cases where a warning isn't as easy to ignore as it is for other people. I would welcome a hotfix to resolve this issue. |
|
error messages shouldn't be considered "ok" or "can be ignored", that's what warning messages are for |
|
This is a warning message (from eslint 4), not an error message. |
|
can we please get a ping on this thread, when the next release goes out with this fix? |
|
If, like me, you're annoyed by the error message, my recommendation would just be to replace your old file with the patched one manually for now. Quick way to do it (from your project directory): The new release will come around soon enough, assuming you don't clear out your modules too often this will clear up your terminal a bit until the next version rolls around. 🙂
|
|
Could you guys bump a new version with this, please? |
N.B. The "can't resolve reference" warnings are coming from eslint-plugin-react and can be safely ignored until a version of eslint-plugin-react containing PR #1292 is released. See: airbnb/javascript#1488 jsx-eslint/eslint-plugin-react#1292
N.B. The "can't resolve reference" warnings are coming from eslint-plugin-react and can be safely ignored until a version of eslint-plugin-react containing PR #1292 is released. See: airbnb/javascript#1488 jsx-eslint/eslint-plugin-react#1292
|
Please publish this on NPM asap. |
|
Released in v7.2.0, really sorry for the delay. |
|
@yannickcr Thank you! |
|
Thank you for the release!! |
See: #1290