Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#969 fix: exception for jsx-no-duplicate-props #1237

Merged
merged 2 commits into from
Jul 29, 2017

Conversation

marcelmokos
Copy link
Contributor

jsx-no-duplicate-props is causing error.
TypeError: name.toLowerCase is not a function.
When <Element {...props}> is used.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could you please provide a test case to prevent regressions?

That would help demonstrate when the name could be a non-string.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb
Copy link
Member

ljharb commented Jul 20, 2017

Sorry for the inconvenience; I've just merged a refactor to start using arrow functions. Would you mind rebasing?

I'll merge within the next day or so, if no objections, after that's done.

marcelmokos and others added 2 commits July 24, 2017 00:04
jsx-no-duplicate-props is causing error. 
TypeError: name.toLowerCase is not a function. 
When <Element {...props}> is used.
@ljharb ljharb merged commit 38a15ea into jsx-eslint:master Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants