-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input with type checkbox does flags checked
attribute as unknown property in v7.31.3
#3383
Comments
checked
attribute as unknown propertychecked
attribute as unknown property in v7.31.3
Thanks, i'll definitely fix Custom HTML element attributes that don't start with |
v7.31.4 will be out once all the tests pass from 6128f9a. |
The disableBodyScroll(container, {
allowTouchMove: el => {
while (el && el !== document.body) {
if (el.getAttribute('body-scroll-lock-ignore') !== null) {
return true;
}
el = el.parentElement;
}
},
}); <div id="container">
<div id="scrolling-map" body-scroll-lock-ignore>
...
</div>
</div>
Awesome, thanks for the extremely quick fix! |
gotcha - i'd definitely suggest using a Please file issues if you run into any more issues with standard attributes! |
@ljharb Will do, thanks! I just checked and it looks like there were some issues with the body scroll lock package on iOS and I ended up disabling it in my app, so I'm going to remove that attribute and everything else should be good. The rest of my app has linted successfully. |
Following up on #3380, I've just installed v7.31.3, but I'm still seeing an issue where the
checked
attribute for a checkbox input is being flagged as unknown.error Unknown property 'checked' found react/no-unknown-property
I'm also seeing this issue when using custom properties (such as
body-scroll-lock-ignore
used by body-scroll-lock, for example), so I'll likely end up having to disable this rule altogether unfortunately. Until the most recent release it never had an issue with these attributes and sincebody-scroll-lock-ignore
is not a standard attribute I'm assuming it's not likely to be added to the whitelist for this plugin.However,
checked
definitely seems like a bug so I figured I would report it.The text was updated successfully, but these errors were encountered: