react/no-unknown-property throws on valid properties

[AhmadMayo]

I recently upgraded eslint-plugin-react from v7.30.1 to v7.31.2, and when I tried to build, the rule started throwing on valid properties like key, viewBox, fill, d, and other SVG related properties - and none of the in kebab case, or contains a colon in their name.

eslint version: 8.23.0
nextjs version: 12.2.5

[mjchang]

Also getting this for other svg properties as well

• stroke
• strokeWidth
• strokeLinecap
• strokeLinejoin
• transform
• clipRule
• x1
• x2
• y1
• y2

[peter-resmed]

same issue

[grybykm]

Downgrade to version 7.31.1. This is a breaking change and regression in version 7.31.2.

npm i [email protected] -D

[ljharb]

Thanks all; I'm on it and will release a v7.31.3 soon.

@grybykm It's not a "breaking change" if it's not intentional, it's just a bug. Dial it back.

[ljharb]

cc @sjarva; seems #3377 has an issue. If you come up with a roll-forward fix before I get to the revert, I'd prefer to do that.

[apteryxxyz]

This also happens in meta tags with the property property, breaking usage of Open Graph.
(<meta property="og:type" content="website" />)

[AhmadMayo]

@ljharb I think I can do it. Give me 30 mins

[ljharb]

@AhmadMayo awesome, i've already got the test cases:

test cases

in "valid":

    { code: '<svg key="lock" viewBox="box" fill={10} d="d" stroke={1} strokeWidth={2} strokeLinecap={3} strokeLinejoin={4} transform="something" clipRule="else" x1={5} x2="6" y1="7" y2="8"></svg>' },
    { code: '<meta property="og:type" content="website" />' },

if you can make modifications to the existing rule to allow these valid properties that'd be awesome :-)

[ljharb]

@AhmadMayo any update?

[AhmadMayo]

@ljharb added the properties and testing now

[AhmadMayo]

@ljharb PR ready

[sibartlett]

I get Unknown property 'key' found on other elements other than <svg>, such as <a> and <span>

[ljharb]

v7.31.1 has been set to "latest" for now, and v7.31.3 will be released within the next hour.

After it's released, and this is closed, please file new issues if you continue to see issues with v7.31.3. Thanks everyone, and sorry for the inconvenience!

[ljharb]

v7.31.3 is now released.

Please update, and file a new issue if you're still seeing problems.