Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-this-in-sfc false positives #1967

Closed
milesj opened this issue Aug 30, 2018 · 4 comments
Closed

no-this-in-sfc false positives #1967

milesj opened this issue Aug 30, 2018 · 4 comments

Comments

@milesj
Copy link

milesj commented Aug 30, 2018

The following code triggers ESLint errors on the this.reset() line.

class Foo {
  unsubscribe(ticketID) { 
    return dispatch => {
      this.reset();
      dispatch(forceUpdate());

      return null;
    };
  }
}

There is no React or JSX in this file.

@ljharb
Copy link
Member

ljharb commented Aug 30, 2018

Thanks, definitely a bug.

cc @alexzherdev

@alundiak
Copy link

+1

sergei-startsev added a commit to sergei-startsev/eslint-plugin-react that referenced this issue Sep 18, 2018
sergei-startsev added a commit to sergei-startsev/eslint-plugin-react that referenced this issue Sep 18, 2018
sergei-startsev added a commit to sergei-startsev/eslint-plugin-react that referenced this issue Sep 19, 2018
@alundiak
Copy link

@sergei-startsev , @ljharb is that change going to be released as v7.11.2 ?

@ljharb
Copy link
Member

ljharb commented Sep 20, 2018

It will be included in the next version, whatever that is and whenever it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants