Fix crash in prop-types when reassigning props (fixes #345)

jsx-eslint · Dec 5, 2015 · be3b7f3 · be3b7f3
1 parent 7800ab1
commit be3b7f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -566,10 +566,11 @@ module.exports = Components.detect(function(context, components, utils) {
     },
 
     VariableDeclarator: function(node) {
+      var destructuring = node.init && node.id && node.id.type === 'ObjectPattern';
       // let {props: {firstname}} = this
-      var thisDestructuring = node.init && node.init.type === 'ThisExpression' && node.id.type === 'ObjectPattern';
+      var thisDestructuring = destructuring && node.init.type === 'ThisExpression';
       // let {firstname} = props
-      var statelessDestructuring = node.init && node.init.name === 'props' && utils.getParentStatelessComponent();
+      var statelessDestructuring = destructuring && node.init.name === 'props' && utils.getParentStatelessComponent();
 
       if (!thisDestructuring && !statelessDestructuring) {
         return;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -953,6 +953,15 @@ ruleTester.run('prop-types', rule, {
       ecmaFeatures: {
         jsx: true
       }
+    }, {
+      // Validation is ignored on reassigned props object
+      code: [
+        'const statelessComponent = (props) => {',
+        '  let newProps = props;',
+        '  return <span>{newProps.someProp}</span>;',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],