[Fix] no-array-index-key: consider flatMap

jsx-eslint · Feb 11, 2023 · abb4871 · abb4871
1 parent 66b58dd
commit abb4871
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`no-array-index-key`]: consider flatMap ([#3530][] @k-yle)
+
+[#3530]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3530
+
 ## [7.32.2] - 2023.01.28
 
 ### Fixed

diff --git a/docs/rules/no-array-index-key.md b/docs/rules/no-array-index-key.md
@@ -45,6 +45,10 @@ things.findIndex((thing, index) => {
   otherThings.push(<Hello key={index} />);
 });
 
+things.flatMap((thing, index) => (
+  <Hello key={index} />
+));
+
 things.reduce((collection, thing, index) => (
   collection.concat(<Hello key={index} />)
 ), []);

diff --git a/lib/rules/no-array-index-key.js b/lib/rules/no-array-index-key.js
@@ -65,6 +65,7 @@ module.exports = {
       filter: 1,
       find: 1,
       findIndex: 1,
+      flatMap: 1,
       forEach: 1,
       map: 1,
       reduce: 2,

diff --git a/tests/lib/rules/no-array-index-key.js b/tests/lib/rules/no-array-index-key.js
@@ -93,6 +93,9 @@ ruleTester.run('no-array-index-key', rule, {
     {
       code: 'foo.map((bar, i) => <Foo key={String(baz)} />)',
     },
+    {
+      code: 'foo.flatMap((a) => <Foo key={a} />)',
+    },
     {
       code: 'foo.reduce((a, b) => a.concat(<Foo key={b.id} />), [])',
     },
@@ -226,6 +229,10 @@ ruleTester.run('no-array-index-key', rule, {
       code: 'foo.reduce((a, b, i) => a.concat(<Foo key={i} />), [])',
       errors: [{ messageId: 'noArrayIndex' }],
     },
+    {
+      code: 'foo.flatMap((a, i) => <Foo key={i} />)',
+      errors: [{ messageId: 'noArrayIndex' }],
+    },
     {
       code: 'foo.reduceRight((a, b, i) => a.concat(<Foo key={i} />), [])',
       errors: [{ messageId: 'noArrayIndex' }],