Improve errors locations for prop-types

jsx-eslint · May 14, 2015 · 33a8be0 · 33a8be0
1 parent 70fef71
commit 33a8be0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -128,7 +128,7 @@ module.exports = function(context) {
       case 'direct':
         usedPropTypes.push({
           name: node.parent.property.name,
-          node: node
+          node: node.parent.property
         });
         break;
       case 'destructuring':
@@ -139,7 +139,7 @@ module.exports = function(context) {
           }
           usedPropTypes.push({
             name: properties[i].key.name,
-            node: node
+            node: properties[i]
           });
         }
         break;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -253,8 +253,8 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
       errors: [{
         message: '\'name\' is missing in props validation',
         line: 3,
-        column: 23,
-        type: 'MemberExpression'
+        column: 34,
+        type: 'Identifier'
       }]
     }, {
       code: [
@@ -271,8 +271,8 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
       errors: [{
         message: '\'name\' is missing in props validation for Hello',
         line: 3,
-        column: 23,
-        type: 'MemberExpression'
+        column: 34,
+        type: 'Identifier'
       }]
     }, {
       code: [