Deprecate the accessible-emoji rule #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jun 22, 2020
|
Thanks 😄 |
1 task
backwardok
added a commit
to backwardok/eslint-plugin-jsx-a11y
that referenced
this pull request
Mar 25, 2021
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set. This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
backwardok
added a commit
to backwardok/eslint-plugin-jsx-a11y
that referenced
this pull request
Mar 25, 2021
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set. This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
ljharb
pushed a commit
to backwardok/eslint-plugin-jsx-a11y
that referenced
this pull request
Apr 6, 2021
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set. This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627
@luke-john's codepen reveals how our rule produces a worse experience than the native emoji support.
https://codepen.io/anon/pen/ymoBgb