Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem installing / building on zeek 3.0.0 #4

Open
dataolle opened this issue Oct 25, 2019 · 9 comments
Open

Problem installing / building on zeek 3.0.0 #4

dataolle opened this issue Oct 25, 2019 · 9 comments

Comments

@dataolle
Copy link

Get error installing tcprs using zeek package manager zkg:

zkg install tcprs
The following packages will be INSTALLED:
  zeek/jswaro/tcprs (0.2.1)

Proceed? [Y/n]
Running unit tests for "zeek/jswaro/tcprs"
error: failed to run tests for zeek/jswaro/tcprs: package build_command failed, see log in /home/dataolle/.zkg/logs/tcprs-build.log

Logfile below:

=== STDERR ===
make: [build-it] Error 1 (ignored)
/home/dataolle/.zkg/clones/package/tcprs/src/TCPRS.cc:7:10: fatal error: 'OSFinger.h' file not found
#include "OSFinger.h"
         ^~~~~~~~~~~~
1 error generated.
make[3]: *** [CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/src/TCPRS.cc.o] Error 1
make[2]: *** [CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/all] Error 2
make[1]: *** [all] Error 2
make: *** [build-it] Error 2
=== STDOUT ===
Build Directory        : build
Bro Source Directory   : /home/dataolle/zeek/zeek-3.0.0
-- The C compiler identification is Clang 9.0.0
-- The CXX compiler identification is Clang 9.0.0
-- Check for working C compiler: /usr/bin/clang-9
-- Check for working C compiler: /usr/bin/clang-9 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++-9
-- Check for working CXX compiler: /usr/bin/clang++-9 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test cxx11_header_works
-- Performing Test cxx11_header_works - Success
-- Zeek executable      : 
-- Zeek source          : /home/dataolle/zeek/zeek-3.0.0
-- Zeek build           : /home/dataolle/zeek/zeek-3.0.0/build
-- Zeek install prefix  : /usr/local/zeek
-- Zeek plugin directory: /usr/local/zeek/lib/zeek/plugins
-- Zeek debug mode      : false
-- Configuring done
-- Generating done
-- Build files have been written to: /home/dataolle/.zkg/clones/package/tcprs/build
Makefile:11: recipe for target 'build-it' failed
( cd build && make )
make[1]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[2]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target bif-plugin-jswaro_TCPRS-tcprs.bif
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[  5%] [BIFCL] Processing src/tcprs.bif
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[  5%] Built target bif-plugin-jswaro_TCPRS-tcprs.bif
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target bif-plugin-jswaro_TCPRS-tcprs_const.bif
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 11%] [BIFCL] Processing src/tcprs_const.bif
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 11%] Built target bif-plugin-jswaro_TCPRS-tcprs_const.bif
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target bro-plugin-jswaro_TCPRS
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 16%] Creating __bro_plugin__ for jswaro::TCPRS
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 16%] Built target bro-plugin-jswaro_TCPRS
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target generate_outputs
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 16%] Built target generate_outputs
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target bif-init-jswaro_TCPRS
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 16%] Built target bif-init-jswaro_TCPRS
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target copy-scripts-jswaro_TCPRS
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 16%] Built target copy-scripts-jswaro_TCPRS
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Scanning dependencies of target jswaro-TCPRS.linux-x86_64
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
make[3]: Entering directory '/home/dataolle/.zkg/clones/package/tcprs/build'
[ 22%] Building CXX object CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/src/Plugin.cc.o
[ 27%] Building CXX object CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/src/TCPRS.cc.o
CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/build.make:124: recipe for target 'CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/src/TCPRS.cc.o' failed
make[3]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
CMakeFiles/Makefile2:238: recipe for target 'CMakeFiles/jswaro-TCPRS.linux-x86_64.dir/all' failed
make[2]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Makefile:129: recipe for target 'all' failed
make[1]: Leaving directory '/home/dataolle/.zkg/clones/package/tcprs/build'
Makefile:11: recipe for target 'build-it' failed
@jswaro
Copy link
Owner

jswaro commented Oct 25, 2019 via email

@dataolle
Copy link
Author

I guess not.
Also, i see OSFinger.h file in bro-2.6.2/src/OSFinger.h
However it is not present in the zeek-3.0.0/src directory?

Do you now how to remedy this on a ubuntu 18.04 system?
I can successfully install the tcprs package on bro-2.6 on the same system btw, but I like to upgrade to zeek 3.0.0

@jswaro
Copy link
Owner

jswaro commented Oct 25, 2019

They might have removed it with the recent release. I'd ask the Zeek mailing list. If so, then I probably need to remove some heuristics around using the OS fingerprints, or disable them.

@dataolle
Copy link
Author

Maybe it is related to this:
zeek/zeek#417

@dataolle
Copy link
Author

This seem to be it:
zeek/zeek@632e83d

@jswaro
Copy link
Owner

jswaro commented Oct 25, 2019

That's unfortunate. Those passive fingerprinting heuristics will need to be disabled for now to allow builds to go through.

@dnj12345
Copy link

@jswaro

I got it to compile with zeek 3.0.1 after some changes. Opened a PR. Please check it out since I have some concerns w.r.t the changes I made. Because of API changes, some new APIs are not compatible with the APIs tcprs was using.

I have not tested it. Waiting or your input on the changes.

@jswaro
Copy link
Owner

jswaro commented Feb 14, 2020

The changes look sane to me.

@dnj12345
Copy link

dnj12345 commented Feb 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants