Add support for a custom highlighter function. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code works fine when Prismjs is run in a browser to colorize code. Howver, for static site builders such as Metalsmith, we would like to not rely on browser Javascript. Setting an appopriate highlighter method on a notebookjs object allows us to continue the rendering process using Prismjs to highlight code and error cells.
|
Thanks, @bradhowes! This seems like a useful feature. Would you be able to share a reproducible repository/zipfile demonstrating the intended usage? |
|
Thanks @jsvine. I've created a demo repo at https://github.com/bradhowes/notebookjs-highliter |
|
Many thanks, @bradhowes. Looks great, and works for me. Merging. |
|
Now available in v0.3.1, on |
|
Great. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code works fine when Prismjs is run in a browser to colorize code.
However, for static site builders such as Metalsmith, we would like to not
rely on browser Javascript. Setting an appropriate highlighter method on a
notebookjs object allows us to continue the rendering process using Prismjs
to highlight code and error cells and save the resulting HTML to a file.