Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): bump to tezedge 0.6.0 pre-release #511

Merged
merged 2 commits into from
Jul 15, 2024
Merged

feat(deps): bump to tezedge 0.6.0 pre-release #511

merged 2 commits into from
Jul 15, 2024

Conversation

emturner
Copy link
Collaborator

@emturner emturner commented Jul 1, 2024

Context

Fixes RV-17

Description

Manually testing the PR

@emturner emturner marked this pull request as ready for review July 2, 2024 15:45
@johnyob johnyob self-requested a review July 3, 2024 20:17
@johnyob johnyob self-assigned this Jul 3, 2024
@johnyob
Copy link
Collaborator

johnyob commented Jul 3, 2024

Hey @emturner
Thanks for the update 🙏

There were some fixups needed, but I still can't get the CI green. Issue appears to replace-workspace-values script called by buildRustPackage (https://github.com/NixOS/nixpkgs/blob/26d9cafa3461c8ec55a6aa7e76ec0f8db0737ff9/pkgs/build-support/rust/import-cargo-lock.nix#L196)

@emturner emturner force-pushed the emturner-rv-57 branch 2 times, most recently from 522c248 to 92389eb Compare July 12, 2024 19:23
Due to a bug in `replace-workspace-values`, we can no-longer use a cargo git dependency for tezos/tezos.
The issue is documented here: NixOS/nixpkgs#276072.
To fix, we simply update nixpkgs.
@johnyob
Copy link
Collaborator

johnyob commented Jul 15, 2024

The issue with replace-workspace-values was fixed here: NixOS/nixpkgs#276072.

Updating nixpkgs seems to have done the trick

@johnyob johnyob enabled auto-merge (rebase) July 15, 2024 16:29
@johnyob johnyob merged commit f952f81 into main Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants