Lazy-allocate Base64/QuotedPrintable decoders in Rfc2047.DecodeToken()

jstedfast · Aug 27, 2023 · 19b73ba · 19b73ba
1 parent 155445e
commit 19b73ba
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/MimeKit/Utils/Rfc2047.cs b/MimeKit/Utils/Rfc2047.cs
@@ -453,8 +453,8 @@ static unsafe int DecodeToken (Token token, IMimeDecoder decoder, byte* input, b
 		static unsafe string DecodeTokens (ParserOptions options, List<Token> tokens, byte[] input, byte* inbuf, int length)
 		{
 			var decoded = new ValueStringBuilder (length);
-			var qp = new QuotedPrintableDecoder (true);
-			var base64 = new Base64Decoder ();
+			QuotedPrintableDecoder qp = null;
+			Base64Decoder base64 = null;
 			var output = new byte[length];
 			Token token;
 			int len;
@@ -480,10 +480,10 @@ static unsafe string DecodeTokens (ParserOptions options, List<Token> tokens, by
 						}
 
 						// base64 / quoted-printable decode each of the tokens...
-						if (encoding == ContentEncoding.Base64)
-							decoder = base64;
+						if (encoding == ContentEncoding.QuotedPrintable)
+							decoder = qp ??= new QuotedPrintableDecoder (true);
 						else
-							decoder = qp;
+							decoder = base64 ??= new Base64Decoder ();
 
 						outptr = outbuf;
 						outlen = 0;