Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rebased] Check for close() is called when Customization implement Closable #125

Merged
merged 3 commits into from
Apr 12, 2017
Merged

[Rebased] Check for close() is called when Customization implement Closable #125

merged 3 commits into from
Apr 12, 2017

Conversation

vbekiaris
Copy link
Contributor

Rebased #106 with some additional minor fixes:

  • Fixed CacheLoaderClientServerTest#clientMustBeClosedBeforeServer to expect an IllegalStateException (with previous idiom, a fail() was missing after serverCacheLoader.close();)
  • Added Server.java to checkstyle suppresions (copyright in this file was updated in rebased commits)
  • A minor typo was fixed

cruftex and others added 3 commits March 13, 2017 10:06
@cruftex @vbekiaris
Check for close() is called when Customization implement Closable, cl…
0f7c5cc 
…oses jsr107#100
@cruftex @vbekiaris
Check for close() is called when Customization implement Closable (co…
2edc61e 
…mmit adds author), closes jsr107#100
@vbekiaris
Test in CacheLoaderClientServerTest should expect exception to be thr…
9313c28 
…own & minor fixes

* Checkstyle suppression for Server.java (additional copyright header)
* Minor typo in exception thrown from Server.java
@vbekiaris vbekiaris added this to the 1.1.0 milestone Mar 13, 2017
@vbekiaris vbekiaris self-assigned this Mar 13, 2017
@vbekiaris
Copy link
Contributor Author

Fixes #100

@vbekiaris
Copy link
Contributor Author

@cruftex could you please check if you are ok with my additional commit? thanks!

@vbekiaris vbekiaris requested a review from cruftex April 11, 2017 09:22
@cruftex cruftex mentioned this pull request Apr 12, 2017
Closed
cruftex
cruftex approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@cruftex cruftex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vbekiaris vbekiaris merged commit 5d8d2de into jsr107:master Apr 12, 2017
@vbekiaris vbekiaris deleted the fixes/1.1/100-closeable-customizations branch April 12, 2017 04:53
@vbekiaris
Copy link
Contributor Author

Thanks @cruftex for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruftex cruftex cruftex approved these changes

Assignees

@vbekiaris vbekiaris

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vbekiaris @cruftex