-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start/endDates with only YYYY-MM should be valid #142
Comments
+1 Definitely. Nobody wants to know what day you started your studies at college several years ago. But it seems to work already, as this tool should be calling the normal CLI as well. |
+1 Perhaps also accommodating simply using years. As @mwaclawek mentioned, this approach does work when using the online editor, but using the command line returns a JSON error. However the .json is valid, it's actually failed against the schema, maybe the error messages should highlight this?
|
@thisislawatts I don't know how this is checked, but according to this document, the Anyway, we should probably permit any date in the format |
There is one drawback, related to #21. I don't really mind if a date is underspecified, but I would like to be able to cast it do a date so I can order it and/or search through it. Since the endDate is inclusive, it means that I would have to cast an Isn't it simpler to just choose a choose a date, even though it may not be 100% accurate, and keep the strictness of the date fields? (You want to fill out |
Hm, that's a fair point, though if you're only going to specify years, then it seems right that you should accept sort order being a little vague. As long as it's capable of grouping your content by year the order is secondary.
|
@wdoekes Expanding start years to |
@wdoekes to me it seems un-user-friendly to require specifying arbitrary precision in dates. I'd rather accept some vagueness in ordering :) |
Perhaps not. I mainly want to guard against making the json harder to parse programmatically. But if you feel strongly about this, I won't object. |
I was also suprised by having to pick a specific date to get the command line tool to validate. A related problem: I don't have an end date for my current job -- is there a way of saying "Present" or something similar? |
If "present" is used, please keep it lowercase because it is not a proper noun. |
Can we come to an agreement here that all dates should support I don't see any reason not to allow that. It should, of course, be up to the user how specific that information is/must be. And there are valid reasons not to enter the day (or month). Maybe we can also add the "PR needed" label already, @thomasdavis? |
+1 for supporting YYYY-MM-DD, YYYY-MM and YYYY. |
+1 for YYYY[-MM[-DD]] For reference, here is the One possible solution is to register a custom validator in ZSchema. Perhaps we should create a |
Agreed. The date should allow for custom formatting so that YYYY and YYYY-MM are valid entries. |
My power is out at home at the moment but this first on my to-do list. |
@thomasdavis Is it possible to also support the |
@dominicwong617 The theme can display the date in any format, such as "August 2014", "Aug. '14", etc. This issue is about how the date data is stored. |
@mchelen When I used the "August 2014" date format, it failed to export (same problem as @thisislawatts) because
It looks like there is regexp validator for date? I believe you use z-schema for validations and this is where it actually does the validation? While it works fine on the web editor, I cannot actually have an actual working resume in PDF format. Am I missing something? Thank you! |
@dominicwong617 The JSON should not use "August 2014", it should use "2014-08-01". Then the theme will convert "2014-08-01" into a different format for display. |
@mchelen Got it, so I just have to find a theme that does the conversion. Thank you! |
@dominicwong617 Yup that's right, glad to help! |
We need a PR for this, right? To use a different date type? @thomasdavis are we ok on this? edit: I just saw #150. In my opinion, we should definitely consider merging that! |
As we are using ISO8601 for v1.0.0, unspecific dates such as 2015, 2015-01 should be valid too. |
Fixed in v.0.1.1 |
No description provided.
The text was updated successfully, but these errors were encountered: