Fix constraint errors getter #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove presentation logic from implementation and dont filter returned errors by array_unique, business logic requires getErrors to return all existing errors, even if it contains duplicates - make Validator::getErrors() return the same filtered result as before and apply array_unique when setting errors on Validator instance
|
👍 |
justinrainbow
added a commit
that referenced
this pull request
Aug 25, 2014
Fix constraint errors getter
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
…getter Fix constraint errors getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request removes unexpected behaviour from the Constraint::getErrors method and fixes #97:
There is validation logic that depends on error state and determines the failure of more complex validation processes by comparing error counts before and after. If getErrors removes information from error state such logic may fail.
Issue #97 illustrates such a circumstance, see added unit tests.