Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to throw exceptions when an error is encountered #354

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Feb 5, 2017

Add option to throw exceptions when an error is encountered, rather than continuing.

@erayd erayd changed the title Throw exceptions Option to throw exceptions when an error is encountered Feb 5, 2017
@bighappyface
Copy link
Collaborator

@erayd please rebase and update the readme to reflect the new public validate method added in #351

 * Changes API references to use the new Validator::validate() entry point
 * Adds section describing available config options
@erayd
Copy link
Contributor Author

erayd commented Feb 15, 2017

@bighappyface Done :-).

`Factory::__construct()` if you wish to persist them across multiple `validate()` calls.

| Flag | Description |
|------|-------------|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget CHECK_MODE_APPLY_DEFAULTS?

@erayd
Copy link
Contributor Author

erayd commented Feb 15, 2017

@shmax No - I deliberately omitted it, because that feature isn't part of this pull request. Seemed more appropriate to add it in PR #349 after this one is merged.

@shmax
Copy link
Collaborator

shmax commented Feb 15, 2017

Ah, gotcha. Ok. LGTM

Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bighappyface bighappyface merged commit 7eb38e2 into jsonrainbow:master Feb 16, 2017
@erayd erayd deleted the throw-exceptions branch February 16, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants