Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for 4.0.0 #326

Merged
merged 1 commit into from
Oct 27, 2016
Merged

update readme for 4.0.0 #326

merged 1 commit into from
Oct 27, 2016

Conversation

shmax
Copy link
Collaborator

@shmax shmax commented Oct 27, 2016

A lot of people are getting confused by the fact that the readme doesn't reflect the current release version. Until #320 gets merged, this will at least put the documentation in sync with the current state of the code.

@bighappyface @digitalkaoz @nwolff @stamster

@bighappyface bighappyface merged commit 1081a70 into jsonrainbow:master Oct 27, 2016
@j-gao
Copy link

j-gao commented Oct 27, 2016

For the inline references, we should also be using $jsonValidator->check($jsonToValidateObject, (object)['$ref' => 'file://mySchema']); instead of $jsonValidator->check($jsonToValidateObject, $jsonSchemaObject);? At least it's the first one that's working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants