handle negative integers #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,7 +184,7 @@ protected function toNumber($value) | |||
|
|
|||
| protected function toInteger($value) | |||
| { | |||
| if(ctype_digit ($value)) { | |||
| if(is_numeric($value) && (string)(int)$value == $value) { | |||
There was a problem hiding this comment.
Is casting to string here necessary with loose equals?
-1 == "-1" // true
(int)"-1" == "-1" // trueThere was a problem hiding this comment.
Not totally sure of the implications, to be honest. I suppose at some point I should cover all the edges in the tests, but for now I removed the extra cast and the existing tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coercion of negative integers.
Fixes #323
@bighappyface