Support json_decode assoc #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boekkooi-fresh
force-pushed
the
array-as-object
branch
from
d3115a4 to
aff1f4c
Compare
boekkooi-fresh
force-pushed
the
array-as-object
branch
from
aff1f4c to
dd5717a
Compare
|
Hey @bighappyface did you have time to take a look at this PR? |
|
@boekkooi-fresh I have a whole day scheduled to OSS maintenance on Friday and will review it then. |
|
@bighappyface Great! Thank you! I'm looking forward to your comments and sorry for bugging 😄 |
Merged
|
+1 |
|
@bighappyface Thank you for the merge and maintaining this library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraint::CHECK_MODE_TYPE_CASTwas not actively used I would say noHi there,
I was running into the problem where
json_decode($input, true)was not validation as I was hoping.To fix the problem I implemented a special
TypeCheckInterfacethis will now be used to determine if something is a object, array and will do special logic to get properties etc.I need to add some special cases where tests failed because of the array structure.
To use the
json_decode($input, true)with theValidatora user must set the checkMode toConstraint::CHECK_MODE_TYPE_CAST.I hope you like the PR and I'm looking forward to the comments.
Cheers,
Warnar