Fix: Start all messages with a capital letter #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
+1 My 2 cents: a good fast-follow would be to convert the string literals to single-quotes or add the various vars into the double-quoted string to take better advantage of variable interpolation, instead of concatenation operations. Probably micro-optimization when we have more important concerns, but hey... |
bighappyface
added a commit
that referenced
this pull request
Jul 13, 2015
Fix: Start all messages with a capital letter
|
👍 Actually, I was also thinking about consistently using |
2 tasks
jessedc
added a commit
to Beanhunter/SwaggerAssertions
that referenced
this pull request
Aug 11, 2015
Fixes issues introduced with jsonrainbow/json-schema#170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
💁 Some messages already do, others don't - it's just an opinion, but I feel it should be consistent. What do you think?