Promote HHVM. #159
Merged
Promote HHVM. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo has a coverage bigger than 85% and tests works with HHVM. This means HHVM support is enough stable for to make it officially supported.
|
+1 based on your reasoning. I am not an HHVM user so it makes no difference for me, but I do as that an HHVM user/supporter approve to have something more... official. Cool? |
|
@Maks3w I am going to move forward with merging this PR. Thanks for the help 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo has a coverage bigger than 85% and tests works with HHVM. This means HHVM support is enough stable for to make it officially supported.