Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated vendors #135

Closed
wants to merge 1 commit into from
Closed

updated vendors #135

wants to merge 1 commit into from

Conversation

lsv
Copy link
Contributor

@lsv lsv commented Mar 19, 2015

  • Updated all vendors
  • Updated phpunit to version ~4

Fixes #124

@stof
Copy link

stof commented Mar 24, 2015

@justinrainbow should we remove the lock file from the repo to make sure we can install things on PHP 5.3.3 as well ? the current lock file requires 5.3.23+

@bighappyface
Copy link
Collaborator

+1, we don't need to store the composer.lock file and can instead specify the versions of packages in composer.json itself. Pull it out and lets see how the build goes.

@keradus
Copy link
Contributor

keradus commented Mar 27, 2015

ref #139

@bighappyface
Copy link
Collaborator

@lsv please rebase per #139

@@ -40,7 +40,7 @@
},
"require-dev": {
"json-schema/JSON-Schema-Test-Suite": "1.1.0",
"phpunit/phpunit": "~3.7",
"phpunit/phpunit": "~4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should really be ~4.0

@bighappyface
Copy link
Collaborator

Closed with #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider relaxing phpunit version requirement?
5 participants