Constraint::check() uses wrong indefinite article in error message to express the type constraint #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A related changeset in composer is composer/composer#1616 |
hakre
added a commit
to hakre/json-schema
that referenced
this pull request
Jun 9, 2014
…cle in ... ...error message to express the type constraint Type::check() used a wrong indefinte article on occasion. This has been fixed by providing a map of types and their wording so that the correct indefinite article is used, always. - jsonrainbow#104 - composer/composer#1616
…cle in ... ...error message to express the type constraint Type::check() used a wrong indefinte article on occasion. This has been fixed by providing a map of types and their wording so that the correct indefinite article is used, always. - jsonrainbow#104 - composer/composer#1616
|
@justinrainbow have you already seen this? are there any questions? some feedback would be nice. |
|
Thanks for this change and clearing up the error messages. This will be included in the next release. |
justinrainbow
added a commit
that referenced
this pull request
Aug 25, 2014
Constraint::check() uses wrong indefinite article in error message to express the type constraint
hakre
added a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
…cle in ... ...error message to express the type constraint Type::check() used a wrong indefinte article on occasion. This has been fixed by providing a map of types and their wording so that the correct indefinite article is used, always. - jsonrainbow#104 - composer/composer#1616
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
Constraint::check() uses wrong indefinite article in error message to express the type constraint
siwinski
pushed a commit
to siwinski/json-schema
that referenced
this pull request
Apr 20, 2015
…cle in ... ...error message to express the type constraint Type::check() used a wrong indefinte article on occasion. This has been fixed by providing a map of types and their wording so that the correct indefinite article is used, always. - jsonrainbow#104 - composer/composer#1616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making use of composer's validation method (which uses your library), it came to my attention that the error messages given are wrong for the indefinite article.
E.g. it says:
Which is wrong because the wrong indefinite article is used (compare: When to Say "a" or "an" etc.).
The correct form is: