Composer json and schema fix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinrainbow
added a commit
that referenced
this pull request
Dec 9, 2011
Composer json and schema fix
|
Thanks for adding composer support |
|
Damn, now we have a mess. :) I started a larger refactoring here (which also fixes the optional thing): https://github.com/igorw/json-schema @justinrainbow Could you add me on jabber? It's [email protected]. |
|
yeah sorry @igorw pulled first then saw your comment :/ maybe you could also do a pull, so we get one base?! |
|
Done, I hope I didn't mess anything up. |
|
@igorw added you on jabber. Also, I've added this project to travis-ci.org. Looks like this PR ended up making one of the tests fail - are you about ready to make a PR for your changes? |
|
Done #2. EDIT: test is not failing on my branch btw. |
patrickallaert
added a commit
to patrickallaert/json-schema
that referenced
this pull request
Jun 17, 2021
As of PHP 8.1, the following notice could possibly appear: Deprecated: strlen(): Passing null to parameter jsonrainbow#1 ($string) of type string is deprecated in ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READMEso it outputs a nicer formatrequired/optionaloptional is now the default valuecomposer.json