-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The validate-json binary autoload deprecation warning in PHP 7.2+ #574
Comments
@SignpostMarv Yep, we haven't used The current production branch (5.x.x) still uses the old code. I'm not sure why I haven't backported that change - possibly because the bug it was fixing didn't apply to 5.x.x either - but let's keep this issue open, and I'll deal with it for the next backport release. |
It appears Packagist integration got outdated, can you have a look? I recall this is just a matter of a push of a button. |
@bighappyface Could you look at the packagist integration please? |
I don’t have access, unfortunately.
…Sent from my iPhone
On Sep 26, 2019, at 4:32 PM, Erayd ***@***.***> wrote:
@bighappyface Could you look at the packagist integration please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@bighappyface Nor I. Do you still have a useful line of communication with @justinrainbow, and do you think he would be OK settings more admins on this repo (or moving it into an org)? This kind of bus factor is incredibly frustrating. |
I've noticed this happening on my own packages recently; On github under |
@SignpostMarv That still requires having admin access to the repo, which nobody here does. @justinrainbow can do it, but he's usually difficult to contact and slow to respond. |
@erayd ah, my bad- thought it was just about admin access to packagist. |
@SignpostMarv It might be that as well, if the hook hasn't been updated since Packagist deprecated their old one in January. I'm not sure on that count. |
@erayd the master branch commit ref seems to be up-to-date on packagist, but the issue might be that master, 5.x.x & 6.0.0-dev all have the same branch alias configured. |
@SignpostMarv Can you clarify? While 6.0.0-dev is the same as master, 5.x.x is a completely independent branch, which diverged from master quite some time ago. |
@erayd clarification on what I'd misread from the commits; dev-master is the only one with a branch alias, so I don't know if that'd trip up w/ packagist. might suggest adjusting the branch aliases on master & 5.x.x in case that's what's stripping up packagist? |
Ooh, good catch. Sorry, I thought you were talking about something on the packagist site. It's been a while since I've looked at that file in any detail. That particular setup isn't valid for either branch, so we definitely need to correct that! |
When running the validate-json command in cli using PHP 7.2 or later, the following deprecation warning shows:
The text was updated successfully, but these errors were encountered: