Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The validate-json binary autoload deprecation warning in PHP 7.2+ #574

Closed
CupOfTea696 opened this issue May 28, 2019 · 17 comments
Closed

The validate-json binary autoload deprecation warning in PHP 7.2+ #574

CupOfTea696 opened this issue May 28, 2019 · 17 comments

Comments

@CupOfTea696
Copy link

CupOfTea696 commented May 28, 2019

When running the validate-json command in cli using PHP 7.2 or later, the following deprecation warning shows:

PHP Deprecated:  __autoload() is deprecated, use spl_autoload_register() instead in
~/.composer/vendor/justinrainbow/json-schema/bin/validate-json on line 16
@SignpostMarv
Copy link
Contributor

was this fixed already by #401 & 9fe7822 ?

@erayd
Copy link
Contributor

erayd commented Jun 4, 2019

@SignpostMarv Yep, we haven't used __autoload for two years now. However, that change only applies to v6, which doesn't yet have a production release (although it's reasonable stable for most uses).

The current production branch (5.x.x) still uses the old code. I'm not sure why I haven't backported that change - possibly because the bug it was fixing didn't apply to 5.x.x either - but let's keep this issue open, and I'll deal with it for the next backport release.

@erayd
Copy link
Contributor

erayd commented Sep 23, 2019

Resolved by @sanmai in #589.

@erayd erayd closed this as completed Sep 23, 2019
@sanmai
Copy link

sanmai commented Sep 26, 2019

It appears Packagist integration got outdated, can you have a look? I recall this is just a matter of a push of a button.

E.g. the newest version isn't available there yet.

@erayd
Copy link
Contributor

erayd commented Sep 26, 2019

@bighappyface Could you look at the packagist integration please?

@bighappyface
Copy link
Collaborator

bighappyface commented Sep 26, 2019 via email

@erayd
Copy link
Contributor

erayd commented Sep 26, 2019

@bighappyface Nor I.

Do you still have a useful line of communication with @justinrainbow, and do you think he would be OK settings more admins on this repo (or moving it into an org)? This kind of bus factor is incredibly frustrating.

@SignpostMarv
Copy link
Contributor

I've noticed this happening on my own packages recently; On github under repo settings > webhooks packagist there's a log of recent messages, with an option to resend.

@erayd
Copy link
Contributor

erayd commented Sep 27, 2019

@SignpostMarv That still requires having admin access to the repo, which nobody here does.

@justinrainbow can do it, but he's usually difficult to contact and slow to respond.

@SignpostMarv
Copy link
Contributor

@erayd ah, my bad- thought it was just about admin access to packagist.

@erayd
Copy link
Contributor

erayd commented Sep 27, 2019

@SignpostMarv It might be that as well, if the hook hasn't been updated since Packagist deprecated their old one in January. I'm not sure on that count.

@SignpostMarv
Copy link
Contributor

@erayd the master branch commit ref seems to be up-to-date on packagist, but the issue might be that master, 5.x.x & 6.0.0-dev all have the same branch alias configured.

@erayd
Copy link
Contributor

erayd commented Sep 27, 2019

@SignpostMarv Can you clarify? While 6.0.0-dev is the same as master, 5.x.x is a completely independent branch, which diverged from master quite some time ago.

@SignpostMarv
Copy link
Contributor

@erayd clarification on what I'd misread from the commits;

dev-master is the only one with a branch alias, so I don't know if that'd trip up w/ packagist.

might suggest adjusting the branch aliases on master & 5.x.x in case that's what's stripping up packagist?

@erayd
Copy link
Contributor

erayd commented Sep 27, 2019

@justinrainbow ^

@erayd
Copy link
Contributor

erayd commented Sep 27, 2019

Ooh, good catch. Sorry, I thought you were talking about something on the packagist site. It's been a while since I've looked at that file in any detail.

That particular setup isn't valid for either branch, so we definitely need to correct that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants